Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a dialog to display errors, fix recovery validation, add more rules #211

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Jan 29, 2025

IDP-1356 As a person adding a password recovery email, I need a message warning me to not use my IDP account's email address (or its aliases)
IDP-733 Tell user if they provide an MFA label that's too long

Fixed

  • Fix validation for: Tell user if they provide an MFA label that's too long
  • Fix form validation
  • Fix letting primary email be recovery email

Changed

  • Error messages now appear in a dialogue instead of at the top
image image

Feature branch checklist

  • Documentation (README, etc.)
  • Run make format and make depsupdate

@hobbitronics hobbitronics requested a review from a team as a code owner January 29, 2025 02:04
@hobbitronics hobbitronics requested review from briskt, forevermatt, mtompset and jason-jackson and removed request for a team January 29, 2025 02:04
src/2sv/smartphone/VerifyQrCode.vue Outdated Show resolved Hide resolved
src/password/Recovery.vue Show resolved Hide resolved
@hobbitronics hobbitronics merged commit e125622 into main Jan 29, 2025
3 checks passed
@hobbitronics hobbitronics deleted the fix-error-messages branch January 29, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants