Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.0.0-alpha.4 -- update to SimpleSAMLphp 2.2.2, now functional in IdP mode #243

Merged
merged 113 commits into from
Jul 8, 2024
Merged

Release 10.0.0-alpha.4 -- update to SimpleSAMLphp 2.2.2, now functional in IdP mode #243

merged 113 commits into from
Jul 8, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 1, 2024

Changed (breaking)

  • Updated SimpleSAMLphp to 2.2.2 along with all required dependencies
  • Rename all lib directories to src
  • Rename all www directories to public
  • Added PHP type-hinting in module code
  • Updated dockerbuild/config/config.php using the latest SimpleSAMLphp example file (config/config.php.dist).
  • Use the config.php file in the ssp-base image for local development and for automated tests, lightly modified.
  • Changed NameIDPolicy because it must now be an array. Reference IDP-1115
  • The SimpleSAML\Utils classes now require instantiation to call member functions because the methods are no longer static. IDP-1103
  • Converted material module templates to use Twig IDP-898
  • (Temporary) Disabled sildisco IdP discovery and reverted to standard SimpleSAMLphp IdP discovery.

Changed

  • Reformatted PHP code to PSR-12 standard

Added

  • Create a cache directory in the Docker image (required by SimpleSAMLphp 2).

Removed

  • Removed Vagrantfile
  • Removed core:StatisticsWithAttribute authproc as it was moved to another module that is not enabled by default.

Reference

https://itse.youtrack.cloud/issue/IDP-869
https://itse.youtrack.cloud/issue/IDP-900

briskt added 30 commits June 14, 2024 14:10
@briskt
updated SimpleSAMLphp to 2.2 along with required dependencies [skip ci]
79193d8
@briskt
remove fillup/fake-bower-assets
fa02f67 
(replaced by yidas/yii2-composer-bower-skip)
@briskt
rename lib -> src
213247d
@briskt
rename www -> public [skip ci]
6186942
@briskt
update process() typehinting in Auth\ProcessingFilter inherited classes
86d6db3
@briskt
update login() and authenticated() method types in SilAuth
f7be2a9
@briskt
update log() and validateIdP() method types in IdPDisco
158c240
@briskt
add types to FakeSession class inherited from SimpleSAML\Session [ski…
4e045f0 
…p ci]
@briskt
Merge pull request #223 from silinternational/feature/ssp-2-composer
79025f6 
updated SimpleSAMLphp to 2.2 along with required dependencies
@briskt
update config.php for SSP 2
c1d9b92
@briskt
use the same config file in all IdP containers
d3112dc
@briskt
use default config.php for SP containers also
45785f2
@briskt
NameIDPolicy must now be an array [skip ci]
75a6212
@briskt
SimpleSAML Utils now requires instantiation [skip ci]
908ae9d
@briskt
use the default name for crt and pem files [skip ci]
6931f2e
@briskt
Merge pull request #224 from silinternational/feature/ssp-2-rename
77bb8f2 
rename SimpleSAMLphp directories
@briskt
Merge pull request #225 from silinternational/feature/ssp-2-typehint
ca8c0de 
add correct types for classes inherited from SimpleSAMLphp
@briskt
update ssp-utilities and psr3-adapters [skip ci]
b9cc751
@briskt
remove Vagrantfile [skip ci]
c811a01
@briskt
use parens to instantiate a class [skip ci]
7ad6978
@briskt
remove ADMIN_PROTECT_INDEX_PAGE as it's no longer available [skip ci]
a8d2d52
@briskt
use ssp-base 9.3.0 (SimpleSAMLphp 1.19) for test SPs [skip ci]
92f508d 
Since the `admin.protectindexpage` (`ADMIN_PROTECT_INDEX_PAGE`) is no longer supported in SSP 2, it may be easiest to just leave the test SPs on version 1.19. This is fine because we don't use ssp-base in non-Hub SP implementations.
@briskt
convert selectidp-links.php to twig template
d290c54
@briskt
Merge pull request #227 from silinternational/feature/ssp-2-config
65daf43 
update config.php using the SSP 2.2 config.php.dist
@briskt
Merge pull request #228 from silinternational/feature/ssp-2-nameidpolicy
14c76eb 
NameIDPolicy must now be an array
@briskt
Merge pull request #229 from silinternational/feature/ssp-2-utils
6b65a3b 
SimpleSAML Utils now requires instantiation
@briskt
Merge branch 'develop' into feature/ssp2-deps-update [skip ci]
b817428
@briskt
Merge branch 'feature/ssp2-deps-update' into feature/ssp2-use-ssp1-fo…
03f7a60 
…r-sp [skip ci]
@briskt
Merge branch 'feature/ssp2-use-ssp1-for-sp' into feature/ssp2-selecti…
14399d2 
…dp-twig [skip ci]
@briskt
Merge pull request #230 from silinternational/feature/ssp2-deps-update
f6e9ede 
update ssp-utilities and psr3-adapters
briskt added 22 commits June 28, 2024 10:48
@briskt
Merge pull request #239 from silinternational/feature/remove-fingerprint
41cf5a0 
remove certFingerprint attribute
@briskt
Merge branch 'develop' into feature/whitespace-cleanup
b99576c
@briskt
Merge pull request #240 from silinternational/feature/whitespace-cleanup
2b36ad0 
whitespace cleanup
@briskt
PR feedback: also check empty
e5de34a
@briskt
PR feedback: must not call trans twice
0c6914d
@briskt
PR feedback: don't use phpmyadmin/phpmyadmin
b9885e3
@briskt
Merge branch 'develop' into feature/ssp2-loginuserpass-twig
60d562d
@briskt
SonarCloud: add rel="noopener"
96dc5a9
@briskt
Merge pull request #241 from silinternational/feature/ssp2-loginuserp…
e7585d8 
…ass-twig

convert loginuserpass template to Twig
@briskt
Merge pull request #242 from silinternational/feature/remove-actions-…
1383c69 
…services

combine actions-services and docker-compose config
@briskt
PR feedback: escape the whole string, not just spName
6d32926
@briskt
use Twig include function, not the include statement
a790fe6
@briskt
use "if foo is not empty" (rather than "if not foo is empty")
e04a597
@briskt
add type="submit" to button elements
d79deef
@briskt
remove extra space after period
849963a
@briskt
fix incorrect case on errorcode template variable
6cf5309
@briskt
fix missing "forgot password" link
ce78e96
@briskt
fix error "variable \"js\" does not exist"
d1b9be2
@briskt
remove extraneous curly brace in send-manager-mfa template
ff3e7fe
@briskt
fix formatting on list of printable codes
5d0a4a3
@briskt
add error strings in silauth/locales
3f4d9c6
@briskt
fix login error rendering
a618e58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.8% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of work, good job.

@briskt briskt merged commit 8915092 into main Jul 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt

@mtompset mtompset Awaiting requested review from mtompset

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics