Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change getString to getOptionalString where a default is provided #245

Merged
merged 4 commits into from
Jul 8, 2024
Merged

change getString to getOptionalString where a default is provided #245

merged 4 commits into from
Jul 8, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 2, 2024 •
edited
Loading

Changed

  • Change getString calls to getOptionalString where a default value is given. The signature of getString changed in SimpleSAMLphp 2.0, removing the second parameter.
  • Change getBoolean calls to getOptionalBoolean where a default value is given. The signature of getBoolean changed in SimpleSAMLphp 2.0, removing the second parameter.
  • Change getValue calls to type-specific methods

Reference

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@briskt briskt merged commit 6945cda into develop Jul 8, 2024
3 checks passed
@briskt briskt deleted the feature/get-optional-string branch July 8, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt

@mtompset mtompset Awaiting requested review from mtompset

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics