Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add description of environment variables to README and local.env.dist #277

Merged
merged 2 commits into from
Sep 13, 2024
Merged

add description of environment variables to README and local.env.dist #277

merged 2 commits into from
Sep 13, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 12, 2024

Added

  • Add descriptions of environment variables to README and local.env.dist

Removed

  • Removed variable LOGGING_HANDLER. We always set it to stderr and it isn't of much use any other way.

@briskt briskt requested review from a team, forevermatt, mtompset and jason-jackson and removed request for a team September 12, 2024 13:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mtompset
mtompset reviewed Sep 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
mtompset
mtompset reviewed Sep 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
mtompset
mtompset reviewed Sep 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
mtompset
mtompset reviewed Sep 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
mtompset
mtompset reviewed Sep 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
mtompset
mtompset reviewed Sep 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
mtompset
mtompset reviewed Sep 12, 2024
View reviewed changes
README.md Show resolved Hide resolved
@briskt briskt merged commit 15fe0bf into main Sep 13, 2024
3 checks passed
@briskt briskt deleted the develop branch September 13, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtompset mtompset mtompset left review comments

@jason-jackson jason-jackson jason-jackson approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @mtompset @jason-jackson