Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.0.2 -- assign all values nag controller needs #278

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Release 10.0.2 -- assign all values nag controller needs #278

merged 2 commits into from
Sep 17, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Sep 16, 2024

IDP-1043 ssp-base #203: nag.php expects array entries which aren't always being set

Fixed

  • Assign all values needed in the state by the nag.php page.

Changed

  • Refactor ProfileReview.php redirectToProfileReview and redirectToNag methods to pass fewer parameters and reduce code duplication.

@briskt briskt requested a review from a team as a code owner September 16, 2024 11:57
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team September 16, 2024 11:57
@briskt briskt changed the title IDP-1043 -- assign all values nag template needs Release 10.0.2 -- assign all values nag template needs Sep 16, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt changed the title Release 10.0.2 -- assign all values nag template needs Release 10.0.2 -- assign all values nag controller needs Sep 16, 2024
hobbitronics
hobbitronics approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@briskt briskt merged commit bb978d0 into main Sep 17, 2024
3 checks passed
@briskt briskt deleted the idp-1043 branch September 17, 2024 06:27
@briskt
Copy link
Contributor Author

briskt commented Sep 17, 2024

Resolves #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics