Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Configurable tolerance proposal #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ricardoffp
Copy link

I've been using this library and needed to add different tolerance values according to element boundaries.
This allows tolerance configuration as before or as separate properties for each side.

Can be defined as a number for all properties or as an object containing top, right, bottom or left properties and their values. Missing properties use the default 0 value.
@codecov-io
Copy link

Codecov Report

Merging #52 into master will decrease coverage by 1.17%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   91.47%   90.29%   -1.18%     
==========================================
  Files          10       10              
  Lines         129      134       +5     
==========================================
+ Hits          118      121       +3     
- Misses         11       13       +2
Impacted Files Coverage Δ
lib/helpers/in-viewport.js 100% <100%> (ø) ⬆️
lib/helpers/in-container.js 93.75% <100%> (ø) ⬆️
lib/index.js 70% <57.14%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d70c07...94bba8a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants