-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Added HDF5PLUGIN_SYSTEM_LIBRARIES
env. var. to build using system libraries
#333
base: main
Are you sure you want to change the base?
Conversation
Also prevent gcc to use the dynamic library if it is installed on the OS and this is not requested
Tested with conda: no longer link with available system libs if not requested + use them if requested through the |
|
I have only found things like this: https://stackoverflow.com/questions/42585210/extending-setuptools-extension-to-use-cmake-in-setup-py |
if field in ('extra_link_args', 'libraries'): | ||
return [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'side question' not sure I get this part. Why is this returning a list ? I would expect an empty dict.
This PR reworks the management of C libraries in
setup.py
to: