Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Added HDF5PLUGIN_SYSTEM_LIBRARIES env. var. to build using system libraries #333

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Mar 14, 2025

This PR reworks the management of C libraries in setup.py to:

@t20100 t20100 added this to the Next release milestone Mar 14, 2025
@t20100 t20100 marked this pull request as draft March 14, 2025 15:01
@t20100 t20100 marked this pull request as ready for review March 21, 2025 15:48
@t20100
Copy link
Member Author

t20100 commented Mar 21, 2025

Tested with conda: no longer link with available system libs if not requested + use them if requested through the HDF5PLUGIN_SYSTEM_LIBRARIES env. var. (the corresponding pkg-config .pc file must be available).

@t20100
Copy link
Member Author

t20100 commented Mar 21, 2025

setuptools is really not appropriate for building pure-C/C++ dynamic libs such as the hdf5 filter plugins.

@vasole
Copy link
Member

vasole commented Mar 21, 2025

Comment on lines +702 to +703
if field in ('extra_link_args', 'libraries'):
return []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'side question' not sure I get this part. Why is this returning a list ? I would expect an empty dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants