Shifted lognormal uniform #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm super sorry, must have missed the notification. I'll look at this tomorrow. |
sims1253
reviewed
Jan 25, 2025
R/misc.R
Outdated
| #' | ||
| #' A more numerically stable equivalent to \code{log(sum(exp(x)))} | ||
| #' | ||
| #' @source http://tr.im/hH5A |
There was a problem hiding this comment.
The source link seems to be dead
There was a problem hiding this comment.
OK, will replace with a link to Wikipedia
|
Besides the dead link I think this looks splendit :) Unless there is a reference implementation somewhere we could test against, this looks good to me. |
|
Updated the link to source, so hopefully, this is good to go! |
|
Looks good. Gonna have to update the actions for them to pass, but I can do that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
would you like to add a uniform + shifted lognormal mixture distribution? This is useful for reaction times (and cannot be directly built with brms via
mixturebecause the uniform distribution is a zero-parameter distribution and brms doesn't like that).Some background at https://www.martinmodrak.cz/2021/04/01/using-brms-to-model-reaction-times-contaminated-with-errors/
Happy to answer questions / suggestions for the code.