Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Node.js description #1475

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

jjangga0214
Copy link
Contributor

@jjangga0214 jjangga0214 commented Dec 11, 2018

I added 'Asyncronous non-blocking event-driven' in front of the original description. I think they are core characteristics of Node.js, so this will more precisely depict what actually Node.js is, without loosing brevity. Also, these words are used on the first line of introduction on official Node.js website. What's more, by this update, someone who searches something like "async non-blocking framework" might find this repository.

By the way, I reviewed #1431 and #628.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • I have read and understood the instructions for creating a list.
  • This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.
  • The entry in the Awesome list should:
    • Include a short description about the project/theme of the list. It should not describe the list itself.
      Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
    • Be added at the bottom of the appropriate category.
  • The list I'm submitting complies with the below requirements.

I REMOVED THE SECOND SECTION OF PR TEMPLATE FOR SAVING SCROLLING HEIGHT AS THIS PR IS FOR UPDATE

I added 'Asyncronous non-blocking event-driven' in front of the original description. I think they are core characteristics of Node.js, so this will more precisely depict what Node.js is, without loosing brevity. Also, these words are used on the first line of [introduction on official Node.js website](https://nodejs.org/en/about/). What's more, by this update, someone who searches something like "async non-blocking framework" might find this repository.
@sindresorhus sindresorhus changed the title Update readme.md: simple description of Node.js Improve Node.js description Dec 12, 2018
@sindresorhus sindresorhus merged commit f7e67fb into sindresorhus:master Dec 12, 2018
@jjangga0214 jjangga0214 deleted the patch-1 branch January 31, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants