-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Babylon.js #2506
Add Babylon.js #2506
Conversation
@sindresorhus I have filed issues for the three failing items on awesome-lint: Babylon.js playground URLs include hashtags (https://playground.babylonjs.com/#58I88I#186), so awesome-lint incorrectly flags them as duplicates. The other two errors (remark-lint:awesome-heading and remark-lint:awesome-list-item) are caused by the fact that "Babylon.js" has a period in it. Being as this causes other lists like awesome-nodejs to fail, I believe there should be an exception added to when a sentence/title ends with ".js" (or any other extension). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm perfectly fine... I know now... And I'll be taking my Mt back
@zakarialaoui10 I already mentioned the errors above. Bug reports have been filed. |
Please follow the normal formatting of Awesome lists. Links should be linkified text, not plain URL links. |
|
@sindresorhus I tried that in the playground, but it doesn't fit with the |
Yes |
Very well. Changed the Playground format. The only other part is the book links, and those are descriptive. "aka.ms" is necessary to show because it designates that this is a Microsoft project. |
@sindresorhus anything else needed? The latest version of remark-lint-double-link includes the fix for double hashtag links, and I'm trying to see about making a PR for awesome-lint to fix the heading issue. Can this be merged before awesome-lint is updated? |
There are still many entries that have plain URLs. For example:
|
Bump |
I would like to request you add recommendations for what to do in this situation (entries with both a deployed URL and a source folder) to the official rules so that awesome-lint can just object to plain URLs. |
@sindresorhus All plain URLs have been removed. |
|
|
Some items are missing a description. |
Changed all instances of
Switched to using square brackets for everything.
I removed
I did my best to add a description to most links, but they are still missing in one area: the playgrounds. Thanks for bearing it out with me; I really appreciate it. |
@sindresorhus bump. |
BabylonJS and Babylon.js is used, and even
Not all done. |
Capitalization of |
I would place the Playground section above Examples. It's very long and not as useful as many of the sections that come after it. |
Both "JavaScript" and "Babylon.js engine" are moot here as implied by the context. Same with many other entries. |
@sindresorhus The reason I used them is because those are from the official GitHub descriptions of the projects. Is it really okay to modify that? |
https://github.com/Symbitic/awesome-babylonjs
The list contains resources about the popular open-source game engine Babylon.js - a framework for web and native game development written in TypeScript.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.