-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft Sentinel #2753
Add Microsoft Sentinel #2753
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@sindresorhus I went through line-by-line when I checked everything off. Would you care to inform me what I'm missing so I can fix it? |
unicorn 🦄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✌️
|
Updated repository name, no PR name change required (since repository name now matches PR) |
unicorn 🦄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice list.
You have some missing punctuation warnings here : https://github.com/kfriede/awesome-microsoft-sentinel/actions/runs/6644291312/job/18053167510#step:3:10
@@ -643,6 +643,7 @@ | |||
- [Password Cracking](https://github.com/n0kovo/awesome-password-cracking#readme) - The process of recovering passwords from data that has been stored in or transmitted by a system in scrambled form. | |||
- [Security Card Games](https://github.com/Karneades/awesome-security-card-games#readme) - Train your skills and discuss various security topics. | |||
- [Suricata](https://github.com/satta/awesome-suricata#readme) - Intrusion detection/prevention system and network security monitoring engine. | |||
- [Microsoft Sentinel](https://github.com/kfriede/awesome-microsoft-sentinel#readme) - Microsoft Sentinel cloud-native SIEM/SOAR solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should not contain the list title. Also not clear what SIEM/SOAR is. Needs a better description in general.
The list is a bit thin on content. |
It's also not following multiple of the guidelines, like |
https://github.com/kfriede/awesome-microsoft-sentinel
Resources for Microsoft Azure Sentinel and related KQL, SIEM, and SOAR functionality
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Add Name of List
. It should not contain the wordAwesome
.#readme
.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.awesome-name-of-list
.# Awesome Name of List
.awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.