Add new fields in the schema of credit_notes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RushiT0122
reviewed
Jan 13, 2025
tests/base.py
Outdated
| @@ -129,6 +129,9 @@ def record_to_bk_value(self, stream, record): | |||
| def tap_name(self): | |||
| return "tap-xero" | |||
|
|
|||
| def name(self): | |||
| return "tap_tester_xero_connection" | |||
There was a problem hiding this comment.
This change looks out of scope of current issue we are trying to address but if it is required please use the same name as before.
Suggested change
| return "tap_tester_xero_connection" | |
| return "tap_tester_xero_common_connection" |
RushiT0122
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Note:
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code