Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to disable overrides via GET parameter #103

Open
artygus opened this issue Mar 8, 2024 · 2 comments · May be fixed by #104
Open

An option to disable overrides via GET parameter #103

artygus opened this issue Mar 8, 2024 · 2 comments · May be fixed by #104

Comments

@artygus
Copy link

artygus commented Mar 8, 2024

This library probably should not be used in production, however it's not uncommon to sacrifice security for convenience. There's a good guidance on practices to avoid security issues if devs opt-in to use it in non-dev environments, but I think that having a GET parameter that allows injection of 3rd party scripts is too permissive and easy to exploit. I believe this behavior should be disabled by default, or at least there's should be an option to disable it.

I'd appreciate any thoughts on this and will be happy to help with the PR if this proposal sounds sensible.

@5punk
Copy link

5punk commented Mar 11, 2024

We would greatly benefit from this as well.

There should be a differentiation between whitelisting/allowed hostnames to override from vs. CSP script sources. Loading a script from a known source shouldn't imply any JS hosted on those hostnames are valid overridables.

Ex: I wish to load specific JS files from jsDelivr.com, but do not wish for ?imo to accept any script from jsDelivr as valid overrides.
This would lead to an XSS attack.

@artygus artygus linked a pull request Mar 14, 2024 that will close this issue
@avanish-pathak
Copy link

@joeldenning @robmosca

Could we get this fix patched?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants