Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Disable overrides via query string by default #104

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

artygus
Copy link
Contributor

@artygus artygus commented Mar 14, 2024

This PR adds ability to toggle ability to override spas via query string and disables this behavior by default.

Closes #103

Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: 7a1ba54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
import-map-overrides Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joeldenning
Copy link
Member

I agree with this change. Since this alters the default behavior to disable a feature, it is a breaking change rather than a patch. I'll test locally and update the changeset.

@joeldenning joeldenning changed the title [PATCH] Option to toggle overrides via query string [BREAKING] Disable overrides via query string by default Sep 23, 2024
@joeldenning joeldenning merged commit fa6a22c into single-spa:main Sep 23, 2024
2 checks passed
@joeldenning
Copy link
Member

Added some documentation and updated the changeset.

@github-actions github-actions bot mentioned this pull request Sep 23, 2024
@joeldenning
Copy link
Member

@artygus artygus deleted the ag/query-param-override-config branch September 24, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An option to disable overrides via GET parameter
2 participants