Set locals correctly for files with dots in the path. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotted paths are common in versioned folders.
|
slick. |
sintaxi
added a commit
that referenced
this pull request
Jan 4, 2016
Set locals correctly for files with dots in the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into while using Harp for a documentation site.
Our folders have dots in the path for the versions eg.
/v2.0/docs/some-cool-docand I noticed the locals data wasn't being correctly set. Debugging lead me here:terraform/lib/terraform.js
Line 86 in f273c19
This change makes
getCurrentcorrectly handle files with dots in them. Very exciting.Maybe sorta related to #31.