must set cookie before write http body

sipin · Nov 8, 2014 · c617d35 · c617d35
1 parent 927b2dd
commit c617d35
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/TODO b/TODO
@@ -3,7 +3,7 @@
 * XSRF context and pipe handler                             OK
 * change behaiver of default pipe handler                   OK
 * context use ResponseWriter instead of http.ResponseWriter OK
-* panic if write header after body
-* add PipeHandler ErrorPage
+* panic if write header after body                          OK
 * add Session
+* add PipeHandler ErrorPage
 * Example
diff --git a/context.go b/context.go
@@ -141,3 +141,9 @@ func (ctx *Context) parseParams() {
 		ctx.Params[k] = v[0]
 	}
 }
+
+func (ctx *Context) checkHeaderWrite() {
+	if ctx.ResponseWriter.Written() {
+		panic(fmt.Errorf("must write header before body"))
+	}
+}
diff --git a/context_cookie.go b/context_cookie.go
@@ -10,6 +10,7 @@ func (ctx *Context) SetCookie(name string, value interface{}) {
 }
 
 func (ctx *Context) SetExpireCookie(name string, value interface{}, sec int64) {
+	ctx.checkHeaderWrite()
 	cookier := ctx.Server.SecureCookie
 	encoded, err := cookier.Encode(name, value)
 	if err != nil {