Allow customizing username when creating user through OIDC #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyuuk
commented
Jan 29, 2025
| @@ -128,10 +129,16 @@ def redirect_with_query(request, redirect_url): | |||
| return HttpResponseRedirect(redirect_url) | |||
|
|
|||
|
|
|||
| def generate_username(email): | |||
| def generate_username(email, claims): | |||
There was a problem hiding this comment.
for the record, the mozilla-django-oidc documentation is not up to date with the code, this function can actually have 2 args
https://github.com/mozilla/mozilla-django-oidc/blob/main/mozilla_django_oidc/auth.py#L120
sissbruecker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #793
Allow config of oidc claim used for username generation (default to email claim to avoid breaking existing installs)