BUGFIX: Ensure the schema denormalizer passes the arguments by name a…

…nd not by position.
sitegeist · Jun 19, 2024 · 1b50e50 · 1b50e50
1 parent 37761e9
commit 1b50e50
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Classes/Domain/Schema/SchemaDenormalizer.php b/Classes/Domain/Schema/SchemaDenormalizer.php
@@ -88,7 +88,8 @@ private static function convertValueObject(array|int|float|string|bool $value, s
         $parameterReflections = $reflection->getConstructor()->getParameters();
         $convertedArguments = [];
         if (is_array($value)) {
-            foreach ($parameterReflections as $name => $reflectionParameter) {
+            foreach ($parameterReflections as $reflectionParameter) {
+                $name = $reflectionParameter->getName();
                 $type = $reflectionParameter->getType();
                 if ($reflectionParameter->isDefaultValueAvailable() && !array_key_exists($reflectionParameter->getName(), $value)) {
                     continue;

diff --git a/Tests/Unit/Domain/Schema/SchemaNormalizerTest.php b/Tests/Unit/Domain/Schema/SchemaNormalizerTest.php
@@ -22,7 +22,7 @@ public static function denormalizeObjectsWithOptionalParametersDataProvider(): \
         ];
         yield 'PostalAddress with missing parameter in between' => [
             Fixtures\PostalAddress::class,
-            ['streetAddress' => 'Dämonenweg 23', 'addressRegion' => 'Hölle', 'postOfficeBoxNumber' => 666],
+            ['streetAddress' => 'Dämonenweg 23', 'addressRegion' => 'Hölle', 'postOfficeBoxNumber' => '666'],
             new Fixtures\PostalAddress(streetAddress: 'Dämonenweg 23', addressRegion: 'Hölle', postOfficeBoxNumber: '666')
         ];
     }