Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: API v1.3 elysia htmx jsx #8

Merged
merged 34 commits into from
Oct 19, 2023
Merged

refactor: API v1.3 elysia htmx jsx #8

merged 34 commits into from
Oct 19, 2023

Conversation

sjdonado
Copy link
Owner

Aiming to close #7 and to prepare the ground for #6. But first I have to address several architectural pitfalls:

  1. Testing with snapshots is not a good idea at all, and the current stack makes things more difficult for integration/unit testing especially due to server/client coupling. The proposed solution handles testing as high priority, bun is delightful to work with.
  2. The current folder structure is a bit overkill, v2 will try to keep it as minimal as possible. This app does not need multiple layers and division of responsibilities (hopefully we are not the next google).
  3. This interesting idea Inverse search? #6 will require to separate adapters (extracting data for representation) from parsers (extracting metadata for internal logic).

Open to suggestions :)

@sjdonado sjdonado self-assigned this Oct 11, 2023
@sjdonado
feat: search-card + audio-preview components
02093a3 
- bun build js files config
- assets folder structure
- htmx setup
@sjdonado
fix: bun tests openHandler redis connection
cd2d60c
@sjdonado
feat: htmx loading indicator
d850f56
@sjdonado
feat: error-message component
3fc5062
@sjdonado
feat: search-bar ger url from clipboard + cache search id
2aa8b28
@sjdonado
feat: footer + get search count
4a7e800
@sjdonado
feat: audio-preview toggle play with spacebar
038758b
@sjdonado
fix: increment search count even if is returned cached response
8a8e8de
@sjdonado
test: should return 200 Song + Album use cases
0ad0845
@sjdonado
test: should return 200 Playlist integration test
9d3a4dd
@sjdonado
test: should return 200 Artist integration test
76c5d10
@sjdonado
test: should return 200 Podcast Episode + show integration test
c82a5fb
@sjdonado
test: should return 200 Spotify Exclusive content integration test
878e645
@sjdonado
refactor: replace youtube with youTube
ee91aae
@sjdonado sjdonado changed the title [WIP] refactor/v2 elysia htmx jsx refactor/v2 elysia htmx jsx Oct 19, 2023
@sjdonado sjdonado changed the title refactor/v2 elysia htmx jsx Refactor API v1.3 elysia htmx jsx Oct 19, 2023
@sjdonado sjdonado changed the title Refactor API v1.3 elysia htmx jsx refactor: API v1.3 elysia htmx jsx Oct 19, 2023
@sjdonado sjdonado mentioned this pull request Oct 19, 2023
Merged
5 tasks
@sjdonado sjdonado merged commit bd89985 into master Oct 19, 2023
1 check passed
@sjdonado sjdonado deleted the refactor/v2-elysia-htmx-jsx branch October 19, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjdonado sjdonado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't work with mobile links
1 participant
@sjdonado