Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Iceshrimp improvements #1000

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

Jacocococo
Copy link

@Jacocococo Jacocococo commented Aug 21, 2024

Lots of improvements to make the experience better on Iceshrimp. These include:

  • Improvements to emoji reactions
    • Enable reactions by default
    • Synchronize favorites and reacts (Except for on Iceshrimp.NET)
    • Respect max amount of reactions on a post (works for Glitch-Soc too)
    • Disable reaction buttons for remote reactions
    • Place the UI's reaction in the same place as the server has placed it
    • Fix bug where a new Unicode reaction wouldn't show up in the UI before refresh if the status previously had no reactions (not specific to Iceshrimp)
  • Improved quote posts support
    • It's now actually possible to quote a post from Iceshrimp
    • Adds another check to remove the RE: text
    • Fixes crash when viewing a quote post
    • Shows notification of the user's post getting quoted properly
  • Improved announcement display
    • Don't show emoji reactions
    • Correctly show edit time
  • Properly use content types since only MFM is supported
    • Disable settings by default and hide them (users will have to log out and in again to disable the setting if they want to. It shouldn't really matter, but that could possibly solve a problem someone is having after updating)
    • Allow all content types to lower risk of unexpected crashes (this fixes Editing a post on Iceshrimp crashes the app #998)
    • Set MFM as the default content type
  • Hide unsupported features
    • Account notify (Except for on Iceshrimp.NET. Doesn't seem to be supported on the server yet but likely will in the future)
    • News discovery
    • Language selector (Except for on Iceshrimp.NET. Not sure if it works currently, but I at least expect it to do in the future)
    • Filter settings
  • Load instance info immediately on main thread instead of in the background (too useful for it to be worth the unnoticable difference in app opening time)
  • Fix constant app crash after being logged into an Iceshrimp account for some time (see 86b6adf)

(I am aware that this project isn't currently active and don't expect much to be done with this PR in this repo. I started working on it a while ago (as seen in the commit dates) and decided I might as well finish it)

This information is very useful and it's loaded very quickly anyways
- Hide emoji reactions
- Correctly set editedAt
The constructor of AccountSessionManager may need this object which
could lead to a situation where it was being used before it had been
created.
Making it static and moving it to MastodonAPIRequest, the only place it
was being used anyways, seems to fix the issue.
This is specifically for tapping existing reactions on a post if the
user has already reached the instance max
We can be sure it doesn't support anything other than MFM
It's disabled anyways for new users, and allowing all lowers the chance
of crashes from a previously selected option being missing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a post on Iceshrimp crashes the app
1 participant