Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AQI background color scale #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wdibi
Copy link

@wdibi wdibi commented Sep 14, 2020

No description provided.

@vercel
Copy link

vercel bot commented Sep 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/pe62s24yf
✅ Preview: https://aqi-wtf-git-fork-wdibi-feature-aqi-color-scale.skalnik.vercel.app

@obra
Copy link
Collaborator

obra commented Sep 14, 2020

Hi @wdibi - Thanks so much for the contribution.

d3....feels like a pretty heavy hammer for this - It adds about 260k of download and adds a hard dependency on a third-party site, which is something we've tried hard to avoid up to now. I think I'd be happier pulling a single calculation function into app.js

@wdibi
Copy link
Author

wdibi commented Sep 14, 2020

Hey @obra, I can implement a similar solution with chroma.js. Thoughts on its size?
https://bundlephobia.com/[email protected]

@obra
Copy link
Collaborator

obra commented Sep 14, 2020

@wdibi It -looks- like https://stackoverflow.com/a/63775249 should do what we want. Wanna give it a shot with that?

@wdibi
Copy link
Author

wdibi commented Sep 14, 2020

@obra Sure, I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants