Allow manually setting the location #55
Open
+111
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reeseovine
commented
Sep 20, 2024
reeseovine
commented
Sep 20, 2024
reeseovine
commented
Sep 20, 2024
|
I would love for this functionality to be added - Dark Reader supports manually punching in a lat/lon, which is now how I have it configured, but automaticDark doesn't collect my location correctly, and so I still have to use manual time-based settings for this extension. Being able to key in a manual lat/lon would be a great change! @skhzhang what is needed for this to land? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started to implement the feature requested in #51. I have not tested this as I have yet to learn how webextensions work.