Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scope attribute to th tag #63

Merged
merged 2 commits into from
Jan 20, 2025
Merged

add scope attribute to th tag #63

merged 2 commits into from
Jan 20, 2025

Conversation

JacobHearst
Copy link
Contributor

Exactly what it says on the tin, adds the scope attribute for th elements.

@sliemeobn
Copy link
Owner

thanks @JacobHearst for the contribution!

since scope is only used on th, can I ask you to add the extension on the tag type directly?

the dance through a "trait" protocol is simply unnecessary and other attributes also follow this pattern for "single tag usage".

@sliemeobn
Copy link
Owner

🙏

@sliemeobn sliemeobn changed the title Add scope attribute add scope attribute to th tag Jan 20, 2025
@sliemeobn sliemeobn merged commit 2dd3baf into sliemeobn:main Jan 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants