Added better exception messages for dynamic client name validation #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
reviewed
Jan 24, 2025
| public static String validateTypeName(String typeName) { | ||
| if (typeName == null) { | ||
| throw new IllegalArgumentException( | ||
| "Invalid type name: '%s'. Type name does not match the regex pattern %s, please check the GraphQL specification %s" |
There was a problem hiding this comment.
This would print Invalid type name: 'null', right? That's a bit confusing, because a (literal) null would actually be a valid type name :) (at least I think so, https://spec.graphql.org/draft/#sec-Names does not forbid it) Rather say Type name cannot be null or something
jmartisk
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.