Fix to Issue#8 - Viem Bug from misdocumented Viem.writeContract() #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix Issue#8 using suggestions from PR#7. Viem Account type used instead of type Address. 2. Add testnet integration tests of critical operations from the ccip client in the js sdk. Tests Fuji -> Sepolia 3. update README 4. add functionality relating to the PRIVATE_KEY to prefix with '0x' if needed for better devX 5. minor fix the the js docs for getTokenAdminRegistry(). Corrected description of return data.
1. renamed integration test name to -mocked. Updated package.json script for this. 2. Modified package.json to include --detectOpenHandles as viem appears to not shut resources so without this the tests exit with the jest open handles error. 3. Improved README instructions for running tests and clarified the use of Anvil. 4. Refactored constants to ensure the right private keys are used in the right tests. Default anvil key is used in integration-mocked tests. Dev must supply pk for integration-testnet tets/ 5. in clients.ts the mode was replaced to anvil from hardhat for the test clients. Test clients do not throw the error identified in Issue#8 hence the need to have two different types of integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes for packages/ccip-js]