Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rmnhome dynamic config revoke changesets #15951

Merged
merged 25 commits into from
Jan 21, 2025
Merged

Rmnhome dynamic config revoke changesets #15951

merged 25 commits into from
Jan 21, 2025

Conversation

carte7000
Copy link
Contributor

Rmnhome dynamic config revoke changesets

@github-actions GitHub Actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 8df5d87 (rmnhome-dynamic-config-revoke-changesets).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRMNCurseIdempotent 0.00% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@github-actions GitHub Actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 08aabf5 (rmnhome-dynamic-config-revoke-changesets).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRMNUncurseIdempotent 0.00% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@github-actions GitHub Actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and c430738 (rmnhome-dynamic-config-revoke-changesets).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRMNUncurse 0.00% true true false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset true 0s @smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@carte7000 carte7000 marked this pull request as ready for review January 17, 2025 15:30
@carte7000 carte7000 requested review from a team as code owners January 17, 2025 15:30
@carte7000 carte7000 requested a review from a team as a code owner January 17, 2025 18:04
@carte7000 carte7000 enabled auto-merge January 17, 2025 18:20
makramkd
makramkd reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@makramkd makramkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to smoke is not enough, gotta update .github/integration-in-memory-tests.yml with the appropriate reference

@carte7000 carte7000 requested review from a team as code owners January 17, 2025 19:19
@carte7000 carte7000 requested a review from makramkd January 20, 2025 17:16
ecPablo
ecPablo previously approved these changes Jan 20, 2025
View reviewed changes
deployment/ccip/changeset/cs_update_rmn_config.go
return fmt.Errorf("failed to load onchain state: %w", err)
}

rmnHome := state.Chains[c.HomeChainSelector].RMNHome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check if key exists to prevent nil panics?

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
33.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@carte7000 carte7000 requested a review from ecPablo January 20, 2025 20:52
@carte7000 carte7000 added this pull request to the merge queue Jan 21, 2025
njegosrailic
njegosrailic approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@njegosrailic njegosrailic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking about the workflow changes, it looks good to me. I'm not familiar with the code, so you may want to reach out to the TT team as well.

Merged via the queue into develop with commit f367549 Jan 21, 2025
195 of 196 checks passed
@carte7000 carte7000 deleted the rmnhome-dynamic-config-revoke-changesets branch January 21, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njegosrailic njegosrailic njegosrailic approved these changes

@makramkd makramkd makramkd approved these changes

@skudasov skudasov skudasov approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

@ecPablo ecPablo Awaiting requested review from ecPablo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carte7000 @njegosrailic @makramkd @skudasov @ecPablo