Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: create new subtree for evm extraction #15959

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 16, 2025

This PR moves some packages to a new evm/ subtree in preparation for evm extraction:

  • abi
  • assets
  • config/chaintype
  • utils
  • utils/big

Packages in this tree will not be allowed to import the rest of core, so that they can be moved smoothly to another repo later.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to touch this. Will revert if unnecessary...

This comment was marked as resolved.

@jmank88 jmank88 force-pushed the evm-module branch 2 times, most recently from 134ad8a to eeecbfa Compare January 16, 2025 18:10
@jmank88 jmank88 requested a review from pavel-raykov January 16, 2025 18:12
@jmank88 jmank88 force-pushed the evm-module branch 5 times, most recently from 530ea2a to 4fac040 Compare January 16, 2025 19:15
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 530ea2a (evm-module).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestETHKeysController_ChainFailure_InvalidAbandon 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.346666666s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 4fac040 (evm-module).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestLogPoller_BlockTimestamps 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller false 133.333333ms @smartcontractkit/bix-framework, @smartcontractkit/core
TestETHKeysController_Index_Errors 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.343333333s Unknown
TestTransfersController_CreateSuccess_From 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.39s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@jmank88 jmank88 force-pushed the evm-module branch 2 times, most recently from 248f3e2 to e35f609 Compare January 16, 2025 21:17
@jmank88 jmank88 requested a review from DylanTinianov January 16, 2025 21:19
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but only addresses part of the problem. Every file with import updates is having it's stale issues flagged as new 🤔

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and bb49c3e (evm-module).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestRunner_Success_Callback_AsyncJob 33.33% false false false 3 1 2 0 github.com/smartcontractkit/chainlink/v2/core/services/job false 43.19s @smartcontractkit/foundations, @smartcontractkit/core
TestPipelineRunsController_Show_HappyPath 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.49s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant