Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dep #15960

Closed
wants to merge 1 commit into from
Closed

Test dep #15960

wants to merge 1 commit into from

Conversation

pavel-raykov
Copy link
Collaborator

No description provided.

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Scheduled Run Frequency , Detect Changes , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , GolangCI Lint (.) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , SonarQube Scan , lint

1. Replacement directory does not exist: go_core_race_tests

Source of Error:
common/headtracker/types/client.go:7:2: github.com/smartcontractkit/chainlink-framework/chains@v0.0.0-00010101000000-000000000000: replacement directory /Users/pavelraykov/Pavel_dev/chainlink-framework/chains does not exist
common/txmgr/broadcaster.go:24:2: github.com/smartcontractkit/chainlink-framework/chains@v0.0.0-00010101000000-000000000000: replacement directory /Users/pavelraykov/Pavel_dev/chainlink-framework/chains does not exist
common/txmgr/txmgr.go:22:2: github.com/smartcontractkit/chainlink-framework/chains@v0.0.0-00010101000000-000000000000: replacement directory /Users/pavelraykov/Pavel_dev/chainlink-framework/chains does not exist
common/txmgr/broadcaster.go:25:2: github.com/smartcontractkit/chainlink-framework/chains@v0.0.0-00010101000000-000000000000: replacement directory /Users/pavelraykov/Pavel_dev/chainlink-framework/chains does not exist
common/headtracker/head_listener.go:18:2: github.com/smartcontractkit/chainlink-framework/chains@v0.0.0-00010101000000-000000000000: replacement directory /Users/pavelraykov/Pavel_dev/chainlink-framework/chains does not exist

Why: The specified replacement directory for the chainlink-framework/chains module does not exist on the filesystem, causing the Go build process to fail.

Suggested fix: Ensure that the replacement directory /Users/pavelraykov/Pavel_dev/chainlink-framework/chains exists and is accessible. Alternatively, update the go.mod file to point to the correct module path.

2. No required module provides package: go_core_race_tests

Source of Error:
core/chains/evm/types/models.go:26:2: no required module provides package github.com/smartcontractkit/chainlink/v2/common/types; to add it:
	go get github.com/smartcontractkit/chainlink/v2/common/types

Why: The Go build process cannot find the required module github.com/smartcontractkit/chainlink/v2/common/types.

Suggested fix: Run go get github.com/smartcontractkit/chainlink/v2/common/types to add the missing module to your project.

3. Invalid map key type: GolangCI Lint (.)

Source of Error:
common/txmgr/broadcaster.go:144:15: invalid map key type ADDR (missing comparable constraint) (typecheck)
	triggers map[ADDR]chan struct{}
	 ^
common/txmgr/tracker.go:51:19: invalid map key type ADDR (missing comparable constraint) (typecheck)
	enabledAddrs map[ADDR]bool
	 ^
common/txmgr/broadcaster.go:227:25: invalid map key type ADDR (missing comparable constraint) (typecheck)
	eb.triggers = make(map[ADDR]chan struct{})
	 ^

Why: The type ADDR used as a map key does not satisfy the comparable constraint required by Go.

Suggested fix: Ensure that the type ADDR implements the comparable interface or use a different type that satisfies this constraint.

4. Undefined method or field: GolangCI Lint (.)

Source of Error:
common/txmgr/broadcaster.go:222:107: eb.chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	eb.lggr.Warnf("Chain %s does not have any keys, no transactions will be sent on this chain", eb.chainID.String())
	 ^
common/txmgr/broadcaster.go:303:59: addr.String undefined (type ADDR has no field or method String) (typecheck)
	eb.lggr.Debugw("Auto-syncing sequence", "address", addr.String())
	 ^
common/txmgr/broadcaster.go:309:65: addr.String undefined (type ADDR has no field or method String) (typecheck)
	eb.lggr.Debugw("Skipping sequence auto-sync", "address", addr.String())
	 ^
common/txmgr/broadcaster.go:436:38: eb.NewTxAttempt undefined (type *Broadcaster[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, SEQ, FEE] has no field or method NewTxAttempt) (typecheck)
	attempt, _, _, retryable, err := eb.NewTxAttempt(ctx, *etx, eb.lggr)
	 ^
common/txmgr/broadcaster.go:709:65: eb.NewBumpTxAttempt undefined (type *Broadcaster[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, SEQ, FEE] has no field or method NewBumpTxAttempt) (typecheck)
	bumpedAttempt, bumpedFee, bumpedFeeLimit, retryable, err := eb.NewBumpTxAttempt(ctx, etx, attempt, nil, lgr)
	 ^
common/txmgr/broadcaster.go:724:59: eb.NewTxAttemptWithType undefined (type *Broadcaster[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, SEQ, FEE] has no field or method NewTxAttemptWithType) (typecheck)
	newEstimatedAttempt, fee, feeLimit, retryable, err := eb.NewTxAttemptWithType(ctx, etx, lgr, attempt.TxType, fees.OptForceRefetch)
	 ^
common/txmgr/broadcaster.go:776:49: chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	promTimeUntilBroadcast.WithLabelValues(chainID.String()).Observe(duration)
	 ^
common/txmgr/confirmer.go:294:119: fromAddress.String undefined (type ADDR has no field or method String) (typecheck)
	errorList = append(errorList, fmt.Errorf("unable to fetch mined transaction count for address %s: %w", fromAddress.String(), err))
	 ^
common/txmgr/confirmer.go:376:49: ec.chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	promNumConfirmedTxs.WithLabelValues(ec.chainID.String()).Add(float64(len(includedTxs)))
	 ^
common/txmgr/confirmer.go:670:56: ec.NewBumpTxAttempt undefined (type *Confirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE] has no field or method NewBumpTxAttempt) (typecheck)
	bumpedAttempt, bumpedFee, bumpedFeeLimit, _, err = ec.NewBumpTxAttempt(ctx, etx, previousAttempt, previousAttempts, ec.lggr)
	 ^
common/txmgr/confirmer.go:675:46: ec.chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	promNumGasBumps.WithLabelValues(ec.chainID.String()).Inc()
	 ^
common/txmgr/confirmer.go:676:93: bumpedFee.String undefined (type FEE has no field or method String) (typecheck)
	ec.lggr.Debugw("Rebroadcast bumping fee for tx", append(logFields, "bumpedFee", bumpedFee.String(), "bumpedFeeLimit", bumpedFeeLimit)...)
	 ^
common/txmgr/confirmer.go:681:54: ec.chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	promGasBumpExceedsLimit.WithLabelValues(ec.chainID.String()).Inc()
	 ^
common/txmgr/confirmer.go:832:26: ec.NewCustomTxAttempt undefined (type *Confirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE] has no field or method NewCustomTxAttempt) (typecheck)
	attempt, _, err := ec.NewCustomTxAttempt(ctx, *etx, fee, etx.FeeLimit, 0x0, ec.lggr)
	 ^
common/txmgr/confirmer.go:877:28: chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	WithLabelValues(chainID.String()).
	 ^
common/txmgr/confirmer.go:891:29: chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	WithLabelValues(chainID.String()).
	 ^
common/txmgr/resender.go:142:89: er.chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	return fmt.Errorf("Resender failed getting enabled keys for chain %s: %w", er.chainID.String(), err)
	 ^
common/txmgr/resender.go:202:51: fromAddress.String undefined (type ADDR has no field or method String) (typecheck)
	if time.Since(er.lastAlertTimestamps[fromAddress.String()]) >= unconfirmedTxAlertLogFrequency {
	 ^
common/txmgr/resender.go:203:28: in call to findOldestUnconfirmedAttempt, cannot infer CHAIN_ID (common/txmgr/resender.go:217:2) (typecheck)
	oldestAttempt, exists := findOldestUnconfirmedAttempt(attempts)
	 ^
common/txmgr/resender.go:207:40: fromAddress.String undefined (type ADDR has no field or method String) (typecheck)
	er.lastAlertTimestamps[fromAddress.String()] = time.Now()
	 ^
common/txmgr/txmgr.go:259:74: addr.String undefined (type ADDR has no field or method String) (typecheck)
	return fmt.Errorf("abandon failed to update txes for key %s: %w", addr.String(), err)
	 ^
common/txmgr/txmgr.go:426:30: head.BlockNumber undefined (type HEAD has no field or method BlockNumber) (typecheck)
	b.tracker.mb.Deliver(head.BlockNumber())
	 ^
common/txmgr/txmgr.go:490:36: head.BlockNumber undefined (type HEAD has no field or method BlockNumber) (typecheck)
	b.reaper.SetLatestBlockNum(head.BlockNumber())
	 ^
common/txmgr/txmgr.go:496:64: head.BlockNumber undefined (type HEAD has no field or method BlockNumber) (typecheck)
	b.logger.Errorw("Timed out handling head", "blockNum", head.BlockNumber(), "ctxErr", ctx.Err())
	 ^
common/txmgr/txmgr.go:586:91: b.chainID.String undefined (type CHAIN_ID has no field or method String) (typecheck)
	return fmt.Errorf("cannot send transaction from %s on chain ID %s: %w", addr, b.chainID.String(), err)
	 ^
common/txmgr/txmgr.go:593:5: ADDR does not satisfy comparable (typecheck)
	if utils.IsZero(to) {
	 ^
common/headtracker/head_broadcaster.go:138:19: head.BlockNumber undefined (type H has no field or method BlockNumber) (typecheck)
	"headNum", head.BlockNumber(),
	 ^
common/headtracker/head_broadcaster.go:154:68: head.BlockNumber undefined (type H has no field or method BlockNumber) (typecheck)
	"callbackType", reflect.TypeOf(trackable), "blockNumber", head.BlockNumber(), "time", elapsed)
	 ^
common/headtracker/head_listener.go:169:20: blockHeader.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
	if !blockHeader.IsValid() {
	 ^
common/headtracker/head_listener.go:175:20: blockHeader.HasChainID undefined (type HTH has no field or method HasChainID) (typecheck)
	if !blockHeader.HasChainID() || blockHeader.ChainID().String() != chainId.String() {
	 ^
common/headtracker/head_listener.go:176:93: blockHeader.ChainID undefined (type HTH has no field or method ChainID) (typecheck)
	hl.eng.Panicf("head listener for %s received block header for %s", chainId, blockHeader.ChainID())
	 ^
common/headtracker/head_tracker.go:152:22: latestFinalized.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
	if !latestFinalized.IsValid() {
	 ^
common/headtracker/head_tracker.go:156:61: latestFinalized.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	latestChain, err := ht.headSaver.Load(ctx, latestFinalized.BlockNumber())
	 ^
common/headtracker/head_tracker.go:161:17: latestChain.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
	if latestChain.IsValid() {
	 ^
common/headtracker/head_tracker.go:162:27: latestChain.EarliestHeadInChain undefined (type HTH has no field or method EarliestHeadInChain) (typecheck)
	earliest := latestChain.EarliestHeadInChain()
	 ^
common/headtracker/head_tracker.go:165:38: latestChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	"latest_blockNumber", latestChain.BlockNumber(),
	 ^
common/headtracker/head_tracker.go:166:36: latestChain.BlockHash undefined (type HTH has no field or method BlockHash) (typecheck)
	"latest_blockHash", latestChain.BlockHash(),
	 ^
common/headtracker/head_tracker.go:188:22: latestFinalized.IsValid undefined (type HTH has no field or method IsValid) (typecheck)
	if !latestFinalized.IsValid() {
	 ^
common/headtracker/head_tracker.go:192:19: headWithChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	if headWithChain.BlockNumber() < latestFinalized.BlockNumber() {
	 ^
common/headtracker/head_tracker.go:194:47: headWithChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	ht.log.With("head_block_num", headWithChain.BlockNumber(),
	 ^
common/headtracker/head_tracker.go:195:53: latestFinalized.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	"latest_finalized_block_number", latestFinalized.BlockNumber()).
	 ^
common/headtracker/head_tracker.go:200:19: headWithChain.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	if headWithChain.BlockNumber()-latestFinalized.BlockNumber() > int64(ht.htConfig.MaxAllowedFinalityDepth()) {
	 ^
common/headtracker/head_tracker.go:202:20: latestFinalized.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	latestFinalized.BlockNumber(), headWithChain.BlockNumber(), ht.htConfig.MaxAllowedFinalityDepth())
	 ^
common/headtracker/head_tracker.go:215:57: head.BlockNumber undefined (type HTH has no field or method BlockNumber) (typecheck)
	ht.log.Debugw(fmt.Sprintf("Received new head %v", head.BlockNumber()),
	 ^
common/headtracker/head_tracker.go:216:21: head.BlockHash undefined (type HTH has no field or method BlockHash) (typecheck)
	"blockHash", head.BlockHash(),
	 ^
common/headtracker/head_tracker.go:217:26: head.GetParentHash undefined (type HTH has no field or method GetParentHash) (typecheck)
	"parentHeadHash", head.GetParentHash(),
	 ^
common/headtracker/head_tracker.go:218:19: head.GetTimestamp undefined (type HTH has no field or method GetTimestamp) (typecheck)
	"blockTs", head.GetTimestamp(),
	 ^

Why: The methods or fields being called on the types ADDR, CHAIN_ID, HEAD, and HTH do not exist.

Suggested fix: Verify that the types ADDR, CHAIN_ID, HEAD, and HTH have the required methods or fields. If they do not, either implement these methods or fields or update the code to use the correct types or methods.

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 18, 2025
@github-actions github-actions bot closed this Mar 25, 2025
@github-actions github-actions bot deleted the test-dep branch March 25, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant