build test #16652
Open
build test #16652
+399
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
|
bolekk
requested changes
Mar 2, 2025
|
|
||
| // ExecuteTask executes a task in parallel, returning ErrMaxParallelExecutionLimitReached if the maximum number of | ||
| // parallel executing tasks has been reached. The task is executed with the given context. | ||
| func (t *parallelExecutionLimiter) ExecuteTask(ctx context.Context, task func(ctx context.Context)) error { |
| // parallel executing tasks has been reached. The task is executed with the given context. | ||
| func (t *parallelExecutionLimiter) ExecuteTask(ctx context.Context, task func(ctx context.Context)) error { | ||
| if !t.sem.TryAcquire(1) { | ||
| return ErrMaxParallelExecutionLimitReached |
There was a problem hiding this comment.
What's the point of failing? What are we going to do if this starts failing in production?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for https://smartcontract-it.atlassian.net/browse/CAPPL-607, executes the capabilities in parallel. Note, it doesn't use a threadpool as suggested on the call as threads in golang are cheap to instantiate, however it does limit the number of capability executions that can run in parallel which is the desired outcome.