-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aleno: Remove rest transport #3754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4dab159 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mxiao-cll
previously approved these changes
Mar 27, 2025
7664a2f
to
1f8dfc6
Compare
1f8dfc6
to
4dab159
Compare
mxiao-cll
approved these changes
Mar 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DF-21204
Description
We want to use the SocketIO API even if the request specifies
"transport": "rest"
, similar to theblocksize-capital
EA.Changes
AdapterEndpoint
.ResponseSchema
type which was used fromprice-http.ts
toprice-socketio.ts
.price-http.ts
transport.adapter.test.ts
which tested the rest transport.fixture.ts
which was only used byadapter.test.ts
.adapter-socket.test.ts
to test that we don't get an error when specifying"transport": "rest"
.Steps to Test
cd packages/sources/aleno/
yarn build && yarn start --env-file=~/env/aleno
"transport": "rest"
works:See in the logs that a subscription was updated, meaning that the socketio transport was used:
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.