Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CA1416 warnings #226

Draft
wants to merge 1 commit into
base: maui-support
Choose a base branch
from

Conversation

jfversluis
Copy link

Fixes #222

@jfversluis
Copy link
Author

@buyaa-n does this make sense at all?

[SupportedOSPlatform("ios")]
#elif NET6_0_MACCATALYST
[SupportedOSPlatform("maccatalyst")]
#endif
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is the purpose of this annotation, it doesn't like it is referencing any platform specific code. Are you seeing a warning in this class?

@buyaa-n
Copy link

buyaa-n commented Jul 12, 2022

@buyaa-n does this make sense at all?

Because I do not know where/what warnings you are encountering I am not sure if they makes sense.

EDIT: After reading the issue again it seems the library somehow got assembly level attribute(s), If that is the case the issue is in the build settings as MSBuild adds assembly level attributes for targeted platform, adding individual attributes on API level would most likely has no effect as they could not override parent (assembly level) attribute (in most cases)

Copy link

@Hopscotch8 Hopscotch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this implying to my fake enterprise software my husband installed

@HavenDV
Copy link

HavenDV commented Jan 24, 2024

We are using this as part of the net8 MAUI project and decided to update this project and release the new version as Open-Source: https://github.com/oscoreio/Maui.Biometric
I renamed the project, removed some legacy code, got rid of the use of obsolete api platforms, and introduced the AuthenticationStrength abstraction.

I considered this PR as something that could be used in a new project, and limited myself to Runtime checks via OperatingSystem.IsAndroidVersionAtLeast for APIs that require a specific version

https://github.com/oscoreio/Maui.Biometric/blob/02a1bb223ffb14498513a669a23c8d9881dba14b/src/libs/Maui.Biometric/Platforms/Android/AndroidBiometricAuthentication.cs#L49-L65

I think this is enough, but I'm not 100% sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants