-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial updates #123
Tutorial updates #123
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
600a5be
to
75e450d
Compare
@@ -106,11 +106,11 @@ | |||
"source": [ | |||
"# clone tifs to tmp directory\n", | |||
"os.chdir('/tmp/')\n", | |||
"if not os.path.exists('/tmp/uavsar-tutorial-data'):\n", | |||
" !git clone --quiet https://github.com/SnowEx/uavsar-tutorial-data.git\n", | |||
"if not os.path.exists('/tmp/uavsar-tutorial-data-2022'):\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the main reason having this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build can't find a needed data file to render outputs...
The repository has been moved to the SnowEx organization.
Yup. Just found another (hopefully) last path that was outdated. |
Unfortunately the call to add terrain lables to a plot using contextily does not render. Only a small stylistic change and the main content of the tutorial is still preserved.
@@ -174,7 +174,8 @@ | |||
"ax.set_ylim(38.75, 39.3)\n", | |||
"\n", | |||
"# Add background map\n", | |||
"cx.add_basemap(ax, crs=img.rio.crs, source = cx.providers.Stamen.TerrainLabels)\n", | |||
"# Unfortunately, the below line does not render as of 20240301\n", | |||
"# cx.add_basemap(ax, crs=img.rio.crs, source = cx.providers.Stamen.TerrainLabels)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad to see this not working with today's run anymore. Luckily it is not breaking essential parts of the tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sadly since 10/2023 Stamen-provided map tiles require an API key (https://xyzservices.readthedocs.io/en/stable/changelog.html#xyzservices-2023-10-1-october-26-2023)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing and good to know
🚀 Deployed on https://deploy-preview-123--snowex2022.netlify.app |
I am accepting the failure with OS X, given that we can build the website and we have a successful Linux build too. |
Since I poked the hornets nest to tried to build the website nearly two years later, I also went ahead and fixed the existing typos.
Main changes: