Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial updates #123

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Tutorial updates #123

merged 4 commits into from
Mar 1, 2024

Conversation

jomey
Copy link
Member

@jomey jomey commented Mar 1, 2024

Since I poked the hornets nest to tried to build the website nearly two years later, I also went ahead and fixed the existing typos.

Main changes:

  • Update a git link for tutorial data that has been moved
  • Fix a couple of typos raised by QA/QC

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jomey jomey requested a review from JessicaS11 March 1, 2024 21:27
@jomey jomey added the preview Trigger a preview deploy to a test instance label Mar 1, 2024
@jomey jomey force-pushed the tutorial-updates branch 2 times, most recently from 600a5be to 75e450d Compare March 1, 2024 21:42
@@ -106,11 +106,11 @@
"source": [
"# clone tifs to tmp directory\n",
"os.chdir('/tmp/')\n",
"if not os.path.exists('/tmp/uavsar-tutorial-data'):\n",
" !git clone --quiet https://github.com/SnowEx/uavsar-tutorial-data.git\n",
"if not os.path.exists('/tmp/uavsar-tutorial-data-2022'):\n",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the main reason having this PR

Copy link
Member

@JessicaS11 JessicaS11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build can't find a needed data file to render outputs...

The repository has been moved to the SnowEx organization.
@jomey
Copy link
Member Author

jomey commented Mar 1, 2024

The build can't find a needed data file to render outputs...

Yup. Just found another (hopefully) last path that was outdated.

Unfortunately the call to add terrain lables to a plot using
contextily does not render. Only a small stylistic change and the main
content of the tutorial is still preserved.
@@ -174,7 +174,8 @@
"ax.set_ylim(38.75, 39.3)\n",
"\n",
"# Add background map\n",
"cx.add_basemap(ax, crs=img.rio.crs, source = cx.providers.Stamen.TerrainLabels)\n",
"# Unfortunately, the below line does not render as of 20240301\n",
"# cx.add_basemap(ax, crs=img.rio.crs, source = cx.providers.Stamen.TerrainLabels)\n",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see this not working with today's run anymore. Luckily it is not breaking essential parts of the tutorial.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sadly since 10/2023 Stamen-provided map tiles require an API key (https://xyzservices.readthedocs.io/en/stable/changelog.html#xyzservices-2023-10-1-october-26-2023)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing and good to know

Copy link

github-actions bot commented Mar 1, 2024

@jomey jomey requested a review from JessicaS11 March 1, 2024 23:00
@jomey
Copy link
Member Author

jomey commented Mar 1, 2024

I am accepting the failure with OS X, given that we can build the website and we have a successful Linux build too.

@jomey jomey merged commit 17b3973 into main Mar 1, 2024
4 of 5 checks passed
@jomey jomey deleted the tutorial-updates branch March 1, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Trigger a preview deploy to a test instance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants