Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm32 support to integration tests #590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add wasm32 support to integration tests #590

wants to merge 3 commits into from

Conversation

kevinheavey
Copy link

I'm not sure if all of this crate works on wasm32 but the integration tests work fine with minor changes to the test code:

  • Use wasm_bindgen_test when target_arch = "wasm32"
  • Replace #[should_panic] with regular assertions in code, because should_panic doesn't work with wasm_bindgen_test
  • Replace u32::MAX in one test with usize::MAX

I also added a wasm-test job to CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevinheavey