Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon patterns #233

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Beacon patterns #233

wants to merge 18 commits into from

Conversation

ItsNickBarry
Copy link
Member

This branch replaces the ManagedProxy contracts with a standard "beacon" pattern, and introduces a DiamondBeacon. The latter is an improvement over the pattern used in the Premia and Insrt contracts that has been frequently recommended as a means of deploying diamond-like contracts via factory.

@ItsNickBarry ItsNickBarry changed the base branch from master to erc2535-compliance December 11, 2023 04:46
@ItsNickBarry ItsNickBarry linked an issue Jan 28, 2024 that may be closed by this pull request
Base automatically changed from erc2535-compliance to master January 29, 2024 16:44
@ItsNickBarry
Copy link
Member Author

Is the Beacon/BeaconProxy naming pattern easy to understand? Would it be better to use something like BeaconEmitter/BeaconReceiver?

@ItsNickBarry ItsNickBarry marked this pull request as ready for review January 29, 2024 19:44
@ItsNickBarry
Copy link
Member Author

Is it okay to reuse the DiamondBase storage location for the DiamondBeacon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add diamond beacon proxy implementation
1 participant