HasPosition Interface
#818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the old Soot, there is a `soot.tagkit.Host` interface which defined methods such as `getJavaSourceStartLineNumber`. Many core classes representing code objects implemented this and allowed libraries implementing Soot to easily define a single method to retrieve position information from various classes. Such an interface is not present in SootUp, and so this PR presents the `sootup.core.model.HasPosition` interface to define what many classes already have as `getPosition`. All classes that already define `getPosition` now implement `HasPosition` as a part of this change.
|
sounds reasonable - e.g. for IDE (read: editor) / UI / LSP tooling this would make sense |
|
@swissiety This is largely motivated by Soot's use in Joern. I'm slowly moving over to SootUp: joernio/joern#4054 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #818 +/- ##
==============================================
+ Coverage 0 63.60% +63.60%
- Complexity 0 3428 +3428
==============================================
Files 0 313 +313
Lines 0 15146 +15146
Branches 0 2565 +2565
==============================================
+ Hits 0 9633 +9633
- Misses 0 4607 +4607
- Partials 0 906 +906 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old Soot, there is a
soot.tagkit.Hostinterface which defined methods such asgetJavaSourceStartLineNumber. Many core classes representing code objects implemented this and allowed libraries implementing Soot to easily define a single method to retrieve position information from various classes.Such an interface is not present in SootUp, and so this PR presents the
sootup.core.model.HasPositioninterface to define what many classes already have asgetPosition. All classes that already definegetPositionnow implementHasPositionas a part of this change.