Skip to content

vscode-insiders-v1.71.1740336433

@julialeex julialeex tagged this 23 Feb 18:24
This commit fixes a bug in the prompt caching feature flag
implementation where we were incorrectly using the enrollment event
result instead of the actual feature flag value. This caused prompt
caching to be enabled for all users regardless of their feature flag
state.

Key changes:
- Added proper feature flag value tracking in PromptBuilder using a
PromptCachingSetting interface
- Separated the enrollment event logging from the feature flag
evaluation
- Ensures the feature flag value is correctly respected while still
tracking enrollment events

The fix maintains proper A/B testing capabilities while correctly
respecting the intended feature flag distribution for prompt caching
functionality.

<!-- Required. See

https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles.
-->

prompt caching should not be used for users who are not enrolled
(non-dot com users)

(cherry picked from commit 9cc241524c0bdfc09c2b6e62b118d9858ca8d57a)


## Test plan

<!-- Required. See
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles.
-->

Co-authored-by: Beatrix <[email protected]>
Assets 2
Loading