index: enable shard merging by default #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
approved these changes
Aug 1, 2024
Comment on lines
1241
to
1242
| fs.Int64Var(&rc.targetSize, "merge_target_size", getEnvWithDefaultInt64("SRC_MERGE_TARGET_SIZE", 2000), "the target size of compound shards in MiB") | ||
| fs.Int64Var(&rc.minSize, "merge_min_size", getEnvWithDefaultInt64("SRC_MERGE_MIN_SIZE", 1800), "the minimum size of a compound shard in MiB") |
There was a problem hiding this comment.
I think we need to change the defaults here since we may have lots of environments which only ever created much smaller shards so may have very low memory limits?
There was a problem hiding this comment.
We discussed this on Zoom. Sourcegraph Cloud instances have a minimum 4GB MEM for indexserver, so the current limits should be ok. Self-hosted customers should have at least a comparable configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to SPLF-175
This enables shard merging by default for zoekt-sourcegraph-indexserver.
Sourcegraph has been using shard merging in production for several years. We have recently confirmed significant performance improvements for queries which are bound by
matchTreeconstruction.I also remove
-merge_max_prioritybecause we have stopped using it.Use
SRC_DISABLE_SHARD_MERGINGto disable shard merging.Test plan:
mostly CI, I did some manual testing to confirm that shard merging is enabled by default for zoekt-sourcegraph-indexserver.