-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add short contributing guide #907
Merged
+17
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Contributing | ||
|
||
We welcome contributions to the project! To propose a change, please fork the repository, make your changes, then submit | ||
a pull request. If the change is significant or potentially controversial, please open an issue first to discuss it. | ||
Zoekt does not require a CLA to contribute. | ||
|
||
Before opening a pull request, make sure that you have run the tests locally: | ||
```sh | ||
go test ./... | ||
``` | ||
|
||
It's also good to run a local smoke test for the relevant component. For example, if you've made changes in | ||
`zoekt-git-index`, you can try indexing a repository locally: | ||
```sh | ||
go run ./cmd/zoekt-git-index /path/to/repo | ||
``` | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a PR template and if no, we should create one so that any person sending a PR fills out a baseline set of information we need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not! Our current issue and PR volume is low, and I haven't seen a need for an issue or PR template yet. We can add one once we start to identify a theme like "I wish people would always include X".