-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizing Calibration Error. #9
base: master
Are you sure you want to change the base?
Conversation
@sourishg Please review the PR |
@pushkalkatara sorry for the delay. Your PR looks good to me. I just have a few suggestions. Right now you're fetching the calibration error from the terminal by searching "Calibration error:" - this seems more like a quick hack (although it's fine). I would suggest you modify the C++ scripts by adding additional popt arguments to export important calibration parameters like calibration error to an external file. Then you should fetch data from that external file using python scripts and make the plots. Also, you should put this script and further scripts inside a folder called |
Like a .yml file for Calibration error and importing the .yml in python and further displaying the plots? I'll make a commit to create a new folder - scripts. Also, i saw a slack channel on kwoc's website for the project. is it active? Actually, i am learning about stereo vision, and want to extract objects using stereo vision from the camera by thresholding the disparity matrix. I would love to learn from you, can you please share some resources on how to start with? I have tried OpenCV's example but on sample images, i need to study it throughly and implement on a video feed. |
You can write the calibration error in the existing YAML file that is being generated after Create another script that can read the calibration error and number of images used from the YAML file and generate the plots. And regarding your query of segmenting disparity maps, I would suggest that you first learn how to generate such disparity maps (just Google and you'll get a bunch of papers). I also have some open source code for generating disparity maps: https://github.com/sourishg/disparity-map |
@sourishg Updated the branch. Please review |
@pushkalkatara This update looks good. Few refinements that I would suggest are:
|
@pushkalkatara please update the PR as requested by @ManashRaja |
I am facing issue with POPT_ARG_NONE. I think it is related to |
@pushkalkatara no, that line is not the issue. What is the exact problem you're facing? Check this file out. I've used |
Sorry for the delay. Please review the PR. |
This solves issue #8
To run the python file -
python visualize.py -w 9 -h 6 -n 27 -s 0.02423 -d "./calib_imgs/1/" -i "left" -o "cam_left.yml" -e "jpg"