Combine vehicle + mech + storage air #32082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psychpsyo
requested review from
metalgearsloth,
Jezithyr,
Partmedia,
EmoGarbage404,
DrSmugleaf and
Chief-Engineer
as code owners
github-actions
bot
added
S: Needs Review
|
ripley mk2 real 100% no fake |
It does not seem to do anything.
deltanedas
reviewed
Sep 11, 2024
H.O.N.K air-tight when? |
wyci |
deltanedas
reviewed
Sep 15, 2024
Content.Server/Atmos/Piping/Unary/EntitySystems/GasCanisterSystem.cs
Outdated
Show resolved
Hide resolved
|
Honestly quite incredible that there has not been a merge conflict yet. |
metalgearsloth
requested changes
Oct 21, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
|
you coming back to this? |
Yes, I want to, just been busy. Will get to this after work today. |
github-actions
bot
removed
the
S: Merge Conflict
|
Actually, I don't have the energy or motivation to look into that failed test right now. |
SlamBamActionman
added
the
S: Untriaged
beck-thompson
added
T: Bugfix
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This unifies the air previously stored in
MechAirComponents,EntityStorageComponents,DisposalUnitComponents,DisposalHolderComponents andCryoPodComponents into a single, newInternalAirComponent.This fixes #19692 and is part of #28412.
Why / Balance
I would like vehicles to return.
Technical details
Same as above.
The new component is pretty much just a holder for internal air, the other systems still need to do a lot of the specifics manually. (containers need to take in air when opened, for example)
Furthermore, this removes the need for
EntityStorageComponents andDisposalUnitComponents to be split between the client and server. They both have been reduced to a single, identical component in Shared. (The only difference before was that the Air was store server-side only, which is now handled by theInternalAirComponentbeing in Server.)Media
Nothing visible has changed, really. The game still behaves the same.
Technically, the amount of air in crates and lockers and stuff has gone from 200 down to 100 and the air in mechs has gone up from 70 to 100.
The exact numbers here don't really matter so I didn't write them all out in the yml files.
The numbers for the gas tanks remain identical to what they used to be though.
Requirements
Breaking changes
"many such cases"
What broke?
Most components that used to have an
Airproperty now no longer do.The
Airproperty has been moved to a newInternalAirComponent.How to fix it?
Add this new component to any broken entity that needs it and update code to reference it instead of the now non-existent
Airproperty on the other component.Changelog
I would love to tease the return of vehicles here but, knowing my motivation, that's probably a bad idea.