Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back rebalanced salvage weapon researching #32398

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Sep 23, 2024

About the PR

  • changes salvage equipment from tier 1 to tier 2 arsenal, 10k points
  • pka is roundstart and in the secfab/emagged lathes, costs gold instead of silver
  • crushers have recipes again and are in the secfab/emagged lathes, theyre more expensive than before
  • added fauna protection module to the tech, has a one-handed pka and a crusher dagger
  • removed shovel from mining module since on master its the go-to 0-tc weapon module and has no use for actual mining

Why / Balance

  • pka is roundstart gear that you can both buy more of and find tons of on debris
  • you can easily find glaives and daggers on debris and ruins so being able to research them isnt game breaking
  • for war ops, its a tier 2 so you can't immediately get it and it has to compete with xray cannons so you wont see everyone making 20 glaives
  • nonantags cant make them at all and antags either have to emag their lathe making it discoverable or steal a secfab, so its difficult
  • fauna module has a pka so you can safely shoot fish sharks etc later into the round (usually at the end given nobody researches arsenal right now) but also so you have unlimited flight thats better than grappling hook recoil (its really annoying to use)
    since its a t2 arsenal tech it will be hard for the shadow factory to equip every borg with it

Media

pka roundstart and uses gold instead of silver
09:29:55

glaive is expensive, not an issue for salv that want to flesh out their teams weapons but will be an issue for shitters
09:30:35

borg pka is real
09:30:54

module icon is even more real
02:10:15

Requirements

Changelog
🆑

  • tweak: Changed Salvage Weapons to be a tier 2 tech, Experimental Salvage Weaponry.
  • tweak: Crusher weapons are researchable again, PKA is roundstart.
  • add: Added the Fauna Protection Module for borgs, it has a PKA and crusher dagger.

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Sep 23, 2024
Copy link
Contributor

github-actions bot commented Sep 23, 2024

RSI Diff Bot; head commit 187dbe3 merging into 0437ec6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/actions_borg.rsi

State Old New Status
fauna-module Added

Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi

State Old New Status
icon-carp Added

Edit: diff updated after 187dbe3

@@ -391,6 +392,9 @@
- WeaponLaserCannon
- WeaponLaserCarbine
- WeaponXrayCannon
- WeaponCrusher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making these researchable just- removes some progression again. Also, I guarantee, some salvs will refuse to do their jobs until these are researched.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can get them roundstart just by doing debris, its more for if you get really unlucky and cant get enough for the whole team. salv not doing their job has always been a player issue and qm should fire them, you dont need to wait 2 hours for a glaive just to kill debris fish

@Kadeo64
Copy link
Contributor

Kadeo64 commented Sep 23, 2024

no more sci PKA how will I ever powergame now (battlemechs)

@Golinth
Copy link
Contributor

Golinth commented Sep 23, 2024

I’m imagining mass Borg armies with PKA and the dagger. Sounds like a nightmare as security tbh.

@deltanedas
Copy link
Contributor Author

for that to happen you need to let the secfab get stolen or let sci keep an emagged lathe, and it would still be incredibly obvious (like renaming the ai sat beacon to The Shadow Factory)

@Kadeo64
Copy link
Contributor

Kadeo64 commented Sep 23, 2024

for that to happen you need to let the secfab get stolen or let sci keep an emagged lathe, and it would still be incredibly obvious (like renaming the ai sat beacon to The Shadow Factory)

tbf a scientist can just fuck up the camera, emag the lathe, then print a few modules, unemag the lathe via deconstruction, repair camera and then boom no trace

@deltanedas
Copy link
Contributor Author

there was a pr for making emagged lathes have a special board so you cant just hide it in 3 seconds

@Kadeo64
Copy link
Contributor

Kadeo64 commented Sep 23, 2024

there was a pr for making emagged lathes have a special board so you cant just hide it in 3 seconds

did it get merged

@deltanedas
Copy link
Contributor Author

no lol

@Kadeo64
Copy link
Contributor

Kadeo64 commented Sep 23, 2024

no lol

my original plan is still valid then
someone ping armok

@deltanedas
Copy link
Contributor Author

@ARMOKS shadow factory part 2 :trollface:

@ARMOKS
Copy link
Contributor

ARMOKS commented Sep 26, 2024

@ARMOKS shadow factory part 2 :trollface:

Yippe free borg weapons

@deltanedas
Copy link
Contributor Author

.

@Kadeo64
Copy link
Contributor

Kadeo64 commented Oct 17, 2024

.

?

@deltanedas
Copy link
Contributor Author

bumping after 3 weeks of no review

@lzk228
Copy link
Contributor

lzk228 commented Oct 17, 2024

you shall wait

@Kadeo64
Copy link
Contributor

Kadeo64 commented Oct 17, 2024

mmfpr fire text here

@metalgearsloth
Copy link
Contributor

bumping after 3 weeks of no review

oh honey

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 14, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-1000 lines. and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 100-1000 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants