User defined custom emotes

[Nettingman]

About the PR

Added new options in the general tab for the user to be able to define custom emotes.
These emotes then can be accessed from the emote menu for any character.

Why / Balance

I wanted to provide a way to define custom emotes without the need of manually editing the key binding file.

Technical details

This is the foundation for a more complex custom emote system I want to implement. If this PR is accepted, then the feature could be later improved with:

• hotkeys for the custom emotes
• character specific emotes
• keywords in place of pronouns and adjectives to be replaced with the ones associated with the current character

Media

ss14-custom-emotes.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

• add: Added a way to define custom emotes in the Options menu, which can then be used from the emotes menu ingame.

[lzk228]

can you somehow integrate functions in it? so playing on characters with different pronouns there would be not only "her"

and don't know about putting it in settings, maybe it is possible to show a little tooltip under the X button in this emote category? and this button will open the settings tab

[Nettingman]

As I've said in the technical details, I would later improve it with pronouns yes.
A different place to define them could be used I guess. But I have to make a new in-game menu for it.

I didn't want to spend more time with this until I was sure this would be something desired and the PR has a chance to be merged.

If it is not completely hopeless then I will gladly work on these issues/improvements.

[Everturning]

Might be a weird suggestion but what about adding an option to add a sound effect that you can normally use to the emotes?
Like "does a deep chuckle" could be attached to a certain laugh instead of having it be a random laugh.
It could be a drop-down menu of the different player sounds next to the input section.

If this doesn't make sense:
Let's say I wanted my character to laugh a certain way. So I input "chuckles heartily", and then next to that I select the laugh I want, let's say Laugh1.
Then whenever I select it in the emote menu, it'll only play Laugh1, not Laugh2. This makes it way more immersive, so if my character is supposed to talk in a deep voice, then they'll have a deep laugh

[Nettingman]

It's not a weird suggestion at all, I really like it!

Actually I wanted this to be at least identical to how the emoting with chat works, i. e. it should play sounds when you write something like "laughs". However I was pretty disappointed that no sound is played for custom emoting when you try it with something like heartily (I tried the exact same word, lol).

Manually setting what audio should be played would be pretty cool, and it would justify the feature as more than "just another way of doing something, you could already do in chat anyway".

I will have to look into what sounds are whitelisted and blacklisted in different scenarios (like whether the player can beep or not, because they are a borg or not).

[Nettingman]

Thank you for the thorough review! Anything I did not comment on is a fair point and will be fixed/updated when I have the time.

The codebase is a bit new to me, and I haven't really worked with dependency injection that much so far, so I felt a bit lost figuring out basic stuff.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.