Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headphones activated animation now plays again #33158

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ArtisticRoomba
Copy link
Contributor

About the PR

Fixes the little sprite animation that plays when you enable the headphones.

Why / Balance

Broke on #31655
This fixes #31755

SHITCODE ALERT! This is horrible! But, you know, it was just as bad before this change if you look at the old system. So it's equally as bad, but it works this time. I call that a net improvement!

Media

Content Client_cbUcPIPzyi

Within the inner heart I plead,
for you to talk to me
I wanna hear all the good and bad,
the new stories you have
As I drift across the skyyy,
The hours hand turns hiiiigh,
So goooodniiight~

Requirements

Changelog
🆑

  • fix: Headphones now correctly displays the activated sprite.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Nov 4, 2024
@slarticodefast
Copy link
Member

slarticodefast commented Nov 4, 2024

Adding a 0 radius pointlight really feels like a bandaid.
The telescopic shield and possibly other items are affected by the same visual bug by the way.
So the underlying problem of the visuals not updating correctly should be solved instead.

#31655 fixed a related, but not identical visual bug for a few items.
It likely broke in #31312

@ArtisticRoomba
Copy link
Contributor Author

Adding a 0 radius pointlight really feels like a bandaid.

The telescopic shield and possibly other items are affected by the same visual bug by the way.

So the underlying problem of the visuals not updating correctly should be solved instead.

#31655 fixed a related, but not identical visual bug for a few items.

It likely broke in #31312

Yeah, I said it was turbo shitcode. I tried for hours, I don't really know of any other method to have something reveal a layer based on an ItemToggle. Right now it seems there's only a method to reveal layers on a light toggle.

An alternative to this is just have it always play instead of be toggleable.

To fix the underlying issue I would probably copy the system that handles revealing layers on light toggle and have it reveal layers on itemtoggle instead but that's just copy paste shitcode as well.

@ArtisticRoomba
Copy link
Contributor Author

I have used this PR as an excuse to dip my toes into some C#. It will probably take a concerning amount of time. Wish me luck. And I'm sorry in advance if you have to look at what I wrote.

Someone else much more competent than me can implement this if they want to.

@ArtisticRoomba ArtisticRoomba marked this pull request as draft November 5, 2024 05:41
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headphones will no longer give the alternative activated sprite
3 participants