Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow building wallmountables on windows #33165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ian321
Copy link
Contributor

@Ian321 Ian321 commented Nov 4, 2024

About the PR

This PR fixes #31474 by allowing the construction of wall-mountable entities on top of windows.

Why / Balance

The issue was marked as a bug, so this is no more than a bug-fix.

Technical details

  1. Added a new tag to distinguish between windows and directional windows.
  2. Adjusted the conditional to allow windows, but not directional windows.
  • While this "fixes" the bug mentioned above, but it also allows for the placing of construction ghosts behind windows (but not the construction, so its only visual). Any help with this would be appreciated.

Media

Screencast.From.2024-11-04.17-34-57.mp4

Requirements

Breaking changes

None

Changelog

🆑

  • fix: Air-alarms, buttons and more can now be build on windows.

@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Nov 4, 2024

I kinda think wallmounts on windows look bad. They can be mapped this way, but in general we avoid it for that reason.

@deltanedas
Copy link
Contributor

you can still make them by building a wall first then tearing it down, its just annoying

@UbaserB
Copy link
Member

UbaserB commented Nov 5, 2024

I kinda think wallmounts on windows look bad. They can be mapped this way, but in general we avoid it for that reason.

looking bad isnt a good reason for disallowing the feature all together, plenty of things can look bad but it just depends on how you do it

@thebadman4662
Copy link

I kinda think wallmounts on windows look bad. They can be mapped this way, but in general we avoid it for that reason.

looking bad isnt a good reason for disallowing the feature all together, plenty of things can look bad but it just depends on how you do it

Wallmountables on windows are like stunbatoning without word. Sure it might look like shitsec to passengers present but maybe sec just stopped medbay bombing by wanted AOS before they had chance to pull the pin and that action was what was needed.

@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Nov 10, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows don't count as walls
7 participants