Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DisplayVotes doing nothing for a vote #33170

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

DrSmugleaf
Copy link
Member

About the PR

The value was never read

Why / Balance

Technical details

Media

Requirements

Breaking changes

Changelog
🆑

  • fix: Fixed not being able to see vote counts for non-votekick votes.

@deltanedas
Copy link
Contributor

the death of mapvote democracy rip

@TurboTrackerss14
Copy link
Contributor

Honestly I would prefer this being a flag for customvotes.
Its a nice thing to prevent "everyone votes for the first option" or whichever has highest votes just getting landslided.

I noticed a fairly clear split away from "90% votes for option 1" when this bug was occuring.

(it also is nice for mapvotes too because people would voteswap at the last second to even out votes etc etc)

@PJB3005 PJB3005 merged commit 8f87bad into space-wizards:master Nov 5, 2024
12 checks passed
iaada pushed a commit to iaada/space-station-14 that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants