Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new sprites for shotgun shell boxes #33176

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

SpaceRox1244
Copy link
Contributor

About the PR

Replaces the generic grey box used for shotgun shells with ammo boxes that are more akin to the ammo boxes used for other ammo types.

Why / Balance

Just visual style consistency. Those massive cotton swab boxes were kind of big and ugly. If this is merged I will likely make a second PR for halving the boxes' size and capacity to bring them in line with the other 1x2 ammo boxes (as well as doubling the count in any pre-existing container fills so that no one is robbed of ammo but that's all little details).

Technical details

Media

shell boxes

Requirements

Breaking changes

Changelog

No CL unless requested because I expect that this is a minor enough visual change.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

RSI Diff Bot; head commit fc735f7 merging into aef7dd5
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/shotgun.rsi

State Old New Status
base Added
beanbag Added
flare Added
incendiary Added
lethal Added
mag-1 Added
mag-2 Added
mag-3 Added
mag-4 Added
mag-alt-1 Added
mag-alt-2 Added
mag-alt-3 Added
mag-alt-4 Added
practice Added
slug Added
tranquilizer Added
uranium Added

Edit: diff updated after fc735f7

@KaiserMaus
Copy link

Box of shotgun shells have more capacity than Magnum box (16>12)

@chromiumboy chromiumboy self-assigned this Nov 10, 2024
@chromiumboy
Copy link
Contributor

The new spites look good to me. I've asked one of the art leads to have a look

@Flareguy Flareguy merged commit af3593a into space-wizards:master Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants