Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Reinforcement codewords on round end #33181

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Errant-4
Copy link
Member

@Errant-4 Errant-4 commented Nov 5, 2024

About the PR

Traitors who are not given codewords (mostly, Reinforcements) no longer display their generated but unused codeword sets on the round end screen

Why / Balance

It's pointless to show a bunch of codewords at the end of the game that no one ever knew about and only exist because it was simpler to hide them than to make them not exist

Media

Before:

Screenshot_2024-11-05_171524

After:

Screenshot_2024-11-05_171240

Requirements

Changelog
🆑 Errant

  • fix: Syndicate Reinforcements no longer list their (hidden and unused) codewords on the Round End window.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Nov 5, 2024
@slarticodefast
Copy link
Member

Tested and works as intended. The code is simple enough and looks good to me.

@slarticodefast slarticodefast self-assigned this Nov 5, 2024
@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 5, 2024
@slarticodefast slarticodefast merged commit da19abd into space-wizards:master Nov 5, 2024
13 checks passed
iaada pushed a commit to iaada/space-station-14 that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants