Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cool lattice #33274

Closed
wants to merge 1 commit into from
Closed

Cool lattice #33274

wants to merge 1 commit into from

Conversation

TheShuEd
Copy link
Member

About the PR

add borders to Lattice

Why / Balance

Visual experiment, looks cool

Media

image
image
image

Requirements

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Nov 12, 2024
@TheShuEd TheShuEd requested a review from Flareguy November 12, 2024 10:32
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Nov 12, 2024
@Kadeo64
Copy link
Contributor

Kadeo64 commented Nov 12, 2024

sovl

@SaphireLattice
Copy link
Contributor

Does this have sufficient readability when there's an empty space tile surrounded by all the lattice?

@Psychpsyo
Copy link
Contributor

Does this have sufficient readability when there's an empty space tile surrounded by all the lattice?

image

Looks like it to me.

@Spessmann
Copy link
Contributor

Spessmann commented Nov 13, 2024 •
edited
Loading

Goon lattice when 😔 (is a negative border even possible)

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@TheShuEd TheShuEd added Size: Very Small Changes: Sprites Changes: Might require knowledge of spriting or visual design. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 14, 2024
@SaphireLattice SaphireLattice added the P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. label Nov 15, 2024
@SlamBamActionman SlamBamActionman added size/S Denotes a PR that changes 10-99 lines. and removed Size: Very Small labels Nov 15, 2024
@Blackern5000
Copy link
Contributor

I really like how it looks when there's just a single small hole but I don't like the way straight lattice edges look, it's way too messy.

@TheShuEd TheShuEd added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Dec 16, 2024
@TheShuEd
Copy link
Member Author

I think that since such a small pr has not been passed for so long, it means that no one wants to take the responsibility to make a final decision. I'll make it for you guys!

@TheShuEd TheShuEd closed this Jan 30, 2025
@deltanedas
Copy link
Contributor

so true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flareguy Flareguy Awaiting requested review from Flareguy

Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TheShuEd @Kadeo64 @SaphireLattice @Psychpsyo @Spessmann @Blackern5000 @deltanedas @SlamBamActionman