Add Sprite changes to Logic Gates to show the input/output state

[0tito]

About the PR

Gates now show the state of their inputs and outputs on the sprite

Why / Balance

Its easier to use them if you can see the states

Media

2024-11-12.10-41-36.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Changelog

[github-actions]

RSI Diff Bot; head commit 04873c0 merging into 8776c71
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/gates.rsi

State	Old	New	Status
logic_a			Added
logic_b			Added
logic_o			Added

Edit: diff updated after 04873c0

[deltanedas]

use separate layers for a/b/output and none of the evil stuff is needed

[0tito]

Is this better? im not exactly the best coder :godo:

[Aeshus]

Thanks for the PR!

There's some small code style issues, and a bug where the code accidentally sets InputA instead of InputB.

Other than that, I like the change and the rest of the visualizer/layering stuff looks good (I don't have personal experience with any of it).

Also, I'm not a maintainer, so this is just a peer review. I may have made some mistakes in my review, or have missed things, so take this review with a grain of salt.

[Aeshus]

LGTM! Thanks for applying the changes/feedback.

I think the only thing now is that you could add yourself to the meta.json's copyright to say that you created the sprites for the light-up states.

Also, make sure to click "resolve" for comments/requested changes once you address it. Otherwise, maintainers may have the false impression that it is still a work-in-progress or ongoing issue.

[slarticodefast]

Cool idea. Needs a little more cleanup before it can be merged.
Thanks to Aeshus and delta for doing the previous reviews.

[slarticodefast]

Quick question: What changes did you make to logic.png? I don't see any difference yet somehow it still doubled in size.

[0tito]

I used it as base when i was making the other sprites, and i think i changed its sprite when i was learning how to change sprites but then instead of reverting it i painted it back to a similar color :godo: i used krita, maybe when i saved i changed something on it?

[slarticodefast]

If it is not changed leave it as it was to preserve the git history and attributions.
And I gave the PR a quick in-game test and the sprites for gates other than the or gate seem to be wrong now when spawning them.

[0tito]

This happens in normal wizden too, iirc oasis has some gates like that, but if you craft them and switch through them normally they work. I can try to change it tho, also how do i "revert" the change to logic.png, would just replacing the sprite with upstream logic.png fix it? or do i have to do something else

[slarticodefast]

Just copying the original sprite back is probably the easiest way. There should be a git command, too, but no idea which one.
Thanks for fixing the other gates! I'll give it another test later.

[slarticodefast]

I tested this and it works as intended for non-pulsed signals. With signal buttons there seems to be some weird behaviour for gates, but that is not the fault of this PR and is happening on master as well. I opened an issue for that #33716.
Thank you for your first contribution!

[0tito]

🫡