Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule amendment - Remove role abandonment aHelp requirement. #33287

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Rule amendment - Remove role abandonment aHelp requirement. #33287

merged 2 commits into from
Nov 15, 2024
+1 −9

Conversation

Titian3
Copy link
Member

@Titian3 Titian3 commented Nov 13, 2024

About the PR

Role abandonment rule.

Why / Balance

Currently there is a requirement for aHelp if you are going to leave the game. In the past we would sometimes open another slot for this but now with cryosleep it is irrelevant and just pointless noise and aHelp volume in the aHelp relay we currently don't need.

Technical details

Just rule text edit.

Media

NA

Requirements

Breaking changes

NA

Changelog
NA

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Nov 13, 2024
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Nov 13, 2024
@K-Dynamic
Copy link
Contributor

I would recommend adding a cryosleeper to the nukie planet then

@Chubbicous
Copy link
Contributor

Important jobs/roles like nukies and AI can't really "cryosleep" though

@Titian3
Copy link
Member Author

Titian3 commented Nov 13, 2024 •
edited
Loading

Important jobs/roles like nukies and AI can't really "cryosleep" though

Sounds like a easy mechanical/mapping issue to be fixed. Added the details to issues. #33295 #33296

@slarticodefast slarticodefast added S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Nov 13, 2024
slarticodefast
slarticodefast approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an internal discussion thread to confirm this is ok for the other admins. We will also have to update the wiki server rules page at the same time this is merged into stable.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
nikthechampiongr
nikthechampiongr approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nikthechampiongr nikthechampiongr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin discussion concluded. Admins approve of this rule change.

@slarticodefast
Copy link
Member

slarticodefast commented Nov 14, 2024 •
edited
Loading

grafik

This datafield should be set to false for all command job prototypes to remove the
You are playing a job that is important for Game Progression. If you have to disconnect, please notify the admins via ahelp.
message in the chat at roundstart.

Edit: Made a quick push myself. This is goot to hotfix.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 14, 2024
@slarticodefast slarticodefast added P: High Priority: Much higher than other items, but isn't an emergency. C: Of Admin Interest Categorisation: Deals with something that admins should weigh in on. A: Command Area: Command department, where it isn't applicable to other departments. and removed S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 14, 2024
@slarticodefast slarticodefast added the I: Hotfix PR Intent: Something that should be applied via hotfix procedure. label Nov 14, 2024
@slarticodefast slarticodefast changed the base branch from master to stable November 14, 2024 23:58
@slarticodefast slarticodefast changed the base branch from stable to master November 14, 2024 23:58
@keronshb keronshb changed the base branch from master to stable November 15, 2024 00:29
@keronshb keronshb changed the base branch from stable to master November 15, 2024 00:30
@slarticodefast slarticodefast changed the base branch from master to stable November 15, 2024 00:33
@slarticodefast slarticodefast changed the base branch from stable to master November 15, 2024 00:34
@SaphireLattice SaphireLattice force-pushed the Rules-remove-ahelp-requirement-for-cryo branch from c39d295 to ac3aa90 Compare November 15, 2024 01:57
@SaphireLattice SaphireLattice changed the base branch from master to stable November 15, 2024 02:02
@slarticodefast slarticodefast self-assigned this Nov 15, 2024
@metalgearsloth metalgearsloth merged commit 530a741 into space-wizards:stable Nov 15, 2024
11 of 12 checks passed
@slarticodefast slarticodefast mentioned this pull request Nov 15, 2024
Merged
@SaphireLattice
Copy link
Contributor

For the record: Count me fixing up this for merging into stable as my approval per the hotfix procedure

SaphireLattice added a commit to SaphireLattice/space-station-14 that referenced this pull request Nov 15, 2024
@SaphireLattice
Merge hotfix space-wizards#33287 from "stable" into "master"
f75be07 
- Rule amendment - Remove role abandonment aHelp requirement. (space-wizards#33287)
- Merges PR space-wizards#33324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

@nikthechampiongr nikthechampiongr nikthechampiongr approved these changes

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404

Assignees

@slarticodefast slarticodefast

Labels
A: Command Area: Command department, where it isn't applicable to other departments. C: Of Admin Interest Categorisation: Deals with something that admins should weigh in on. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. I: Hotfix PR Intent: Something that should be applied via hotfix procedure. P: High Priority: Much higher than other items, but isn't an emergency. size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Titian3 @K-Dynamic @Chubbicous @slarticodefast @SaphireLattice @nikthechampiongr @metalgearsloth @SlamBamActionman